----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29991/#review68601 -----------------------------------------------------------
src/tests/master_allocator_tests.cpp <https://reviews.apache.org/r/29991/#comment112919> What is the reason to leave this expectation? I think it's covered by the new code in /r/29990. src/tests/master_allocator_tests.cpp <https://reviews.apache.org/r/29991/#comment112921> It looks like removing these expectations (actually replacing them with `EXPECT_CALL(*this, deactivateFramework(_)).WillRepeatedly(DoDefault());` from /r/29990) changes the original logic. Do I miss the point? src/tests/master_allocator_tests.cpp <https://reviews.apache.org/r/29991/#comment112924> It looks for me like removing these will change the original intention, see above. src/tests/master_allocator_tests.cpp <https://reviews.apache.org/r/29991/#comment112925> See comment above. - Alexander Rukletsov On Jan. 16, 2015, 11:12 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29991/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2015, 11:12 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-2232 > https://issues.apache.org/jira/browse/MESOS-2232 > > > Repository: mesos-git > > > Description > ------- > > Removed unnecessary allocator expectations in the tests. > > > Diffs > ----- > > src/tests/master_allocator_tests.cpp > 2430622d09c7ef1e020e2eb8f97444e7efc7c8ea > src/tests/resource_offers_tests.cpp > d098e7016ac0da7f1d629af099bb1b8fa66da839 > src/tests/slave_recovery_tests.cpp 809822e63b05a21418cd9297c927d656d6fd871d > > Diff: https://reviews.apache.org/r/29991/diff/ > > > Testing > ------- > > make check with many iterations > > > Thanks, > > Ben Mahler > >
