> On Jan. 20, 2015, 8:45 p.m., Jie Yu wrote: > > src/tests/master_allocator_tests.cpp, lines 235-236 > > <https://reviews.apache.org/r/29991/diff/1/?file=824066#file824066line235> > > > > Ditto Alexander's comments. Could you please do a search for > > ```WillRepeatedly(DoDefault())``` and make sure all unncessary such > > ```EXPECT_CALL```s are removed? > > Ben Mahler wrote: > See my comment above to Alexander. I did such a search but it's necessary > to have these to restore the defaults, if there are other expecations in the > test that are overriding the default.
Aha, my bad. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29991/#review68776 ----------------------------------------------------------- On Jan. 16, 2015, 11:12 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29991/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2015, 11:12 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-2232 > https://issues.apache.org/jira/browse/MESOS-2232 > > > Repository: mesos-git > > > Description > ------- > > Removed unnecessary allocator expectations in the tests. > > > Diffs > ----- > > src/tests/master_allocator_tests.cpp > 2430622d09c7ef1e020e2eb8f97444e7efc7c8ea > src/tests/resource_offers_tests.cpp > d098e7016ac0da7f1d629af099bb1b8fa66da839 > src/tests/slave_recovery_tests.cpp 809822e63b05a21418cd9297c927d656d6fd871d > > Diff: https://reviews.apache.org/r/29991/diff/ > > > Testing > ------- > > make check with many iterations > > > Thanks, > > Ben Mahler > >
