----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29991/#review68776 -----------------------------------------------------------
I guess any expection that involves ```.Times``` shouldn't be removed? And we should remove ```WillRepeatedly(DoDefault())``` whenever possible? src/tests/master_allocator_tests.cpp <https://reviews.apache.org/r/29991/#comment113211> Ditto Alexander's comments. Could you please do a search for ```WillRepeatedly(DoDefault())``` and make sure all unncessary such ```EXPECT_CALL```s are removed? src/tests/master_allocator_tests.cpp <https://reviews.apache.org/r/29991/#comment113213> This seems to be necessary (making sure removeSlave is only called at most once, not twice)? src/tests/master_allocator_tests.cpp <https://reviews.apache.org/r/29991/#comment113214> Ditto above. This seems necessary? src/tests/master_allocator_tests.cpp <https://reviews.apache.org/r/29991/#comment113215> Ditto. src/tests/master_allocator_tests.cpp <https://reviews.apache.org/r/29991/#comment113212> Ditto. src/tests/master_allocator_tests.cpp <https://reviews.apache.org/r/29991/#comment113216> Ditto. src/tests/master_allocator_tests.cpp <https://reviews.apache.org/r/29991/#comment113217> Ditto. - Jie Yu On Jan. 16, 2015, 11:12 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29991/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2015, 11:12 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-2232 > https://issues.apache.org/jira/browse/MESOS-2232 > > > Repository: mesos-git > > > Description > ------- > > Removed unnecessary allocator expectations in the tests. > > > Diffs > ----- > > src/tests/master_allocator_tests.cpp > 2430622d09c7ef1e020e2eb8f97444e7efc7c8ea > src/tests/resource_offers_tests.cpp > d098e7016ac0da7f1d629af099bb1b8fa66da839 > src/tests/slave_recovery_tests.cpp 809822e63b05a21418cd9297c927d656d6fd871d > > Diff: https://reviews.apache.org/r/29991/diff/ > > > Testing > ------- > > make check with many iterations > > > Thanks, > > Ben Mahler > >
