----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30074/#review68716 -----------------------------------------------------------
A high-level question: should `maxAllowedAge` be optional? Does it makes sense to have or provide a sane default? src/slave/slave.cpp <https://reviews.apache.org/r/30074/#comment113096> Can we use simply `None()` instead? src/slave/slave.cpp <https://reviews.apache.org/r/30074/#comment113097> It looks like at this point the future is ready and therefore usage is always available. Can we avoid `Option<>` then by providing a sane default until `maxAllowedAge` is loaded? src/tests/slave_tests.cpp <https://reviews.apache.org/r/30074/#comment113098> What is `max_allowed_age`? src/tests/slave_tests.cpp <https://reviews.apache.org/r/30074/#comment113099> Why `3`? Can we use `Clock::advance` instead? - Alexander Rukletsov On Jan. 20, 2015, 1:39 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30074/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2015, 1:39 p.m.) > > > Review request for mesos, Niklas Nielsen and Till Toenshoff. > > > Bugs: mesos-2229 > https://issues.apache.org/jira/browse/mesos-2229 > > > Repository: mesos-git > > > Description > ------- > > Adds and entry `max_allowed_age` to the response of the stats.json endpoint > in the slave. The format of the value is `{double}(days|mins|secs)`. > > The max allowed age value is available only if it is set, which depends on > the flag `--disk_watch_interval` which by default runs every minute (So it > will only be available after the first minute running). > > Modifies the unit test `SlaveTest.MetricsInStatsEndpoint` so it takes into > account the new entry. > > > Diffs > ----- > > src/slave/http.cpp d1cf8a6 > src/slave/slave.hpp 70bd8c1 > src/slave/slave.cpp fca83b3 > src/tests/slave_tests.cpp a85a028 > > Diff: https://reviews.apache.org/r/30074/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
