> On Jan. 20, 2015, 2:06 p.m., Alexander Rukletsov wrote: > > src/slave/slave.cpp, line 3374 > > <https://reviews.apache.org/r/30074/diff/1/?file=826834#file826834line3374> > > > > It looks like at this point the future is ready and therefore usage is > > always available. Can we avoid `Option<>` then by providing a sane default > > until `maxAllowedAge` is loaded?
I like the idea, the question is, which value is a good default? > On Jan. 20, 2015, 2:06 p.m., Alexander Rukletsov wrote: > > src/tests/slave_tests.cpp, line 830 > > <https://reviews.apache.org/r/30074/diff/1/?file=826835#file826835line830> > > > > Why `3`? Can we use `Clock::advance` instead? I think `FUTURE_DISPATCH` works better > On Jan. 20, 2015, 2:06 p.m., Alexander Rukletsov wrote: > > src/tests/slave_tests.cpp, line 828 > > <https://reviews.apache.org/r/30074/diff/1/?file=826835#file826835line828> > > > > What is `max_allowed_age`? I changed the name to `max_allowed_directory_age` which I hope gives more information. It represents the maximum age of a directory before it is scheduled for deletion. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30074/#review68716 ----------------------------------------------------------- On Jan. 20, 2015, 1:39 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30074/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2015, 1:39 p.m.) > > > Review request for mesos, Niklas Nielsen and Till Toenshoff. > > > Bugs: mesos-2229 > https://issues.apache.org/jira/browse/mesos-2229 > > > Repository: mesos-git > > > Description > ------- > > Adds and entry `max_allowed_age` to the response of the stats.json endpoint > in the slave. The format of the value is `{double}(days|mins|secs)`. > > The max allowed age value is available only if it is set, which depends on > the flag `--disk_watch_interval` which by default runs every minute (So it > will only be available after the first minute running). > > Modifies the unit test `SlaveTest.MetricsInStatsEndpoint` so it takes into > account the new entry. > > > Diffs > ----- > > src/slave/http.cpp d1cf8a6 > src/slave/slave.hpp 70bd8c1 > src/slave/slave.cpp fca83b3 > src/tests/slave_tests.cpp a85a028 > > Diff: https://reviews.apache.org/r/30074/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
