----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30112/#review68989 -----------------------------------------------------------
src/tests/protobuf_io_tests.cpp <https://reviews.apache.org/r/30112/#comment113559> Can you kill std:: prefix in this file (by putting using statements in the beginning of this file)? src/tests/protobuf_io_tests.cpp <https://reviews.apache.org/r/30112/#comment113561> This seems to be redundent to me:) src/tests/protobuf_io_tests.cpp <https://reviews.apache.org/r/30112/#comment113562> ``` Try<Nothing> write = ::protobuf::write(...); ASSERT_SOME(write); ``` src/tests/protobuf_io_tests.cpp <https://reviews.apache.org/r/30112/#comment113564> Feel free to add ```using google::protobuf```. Also, please get the result from read and ASSERT_SOME on it. ``` Result<RepeatedPtrField<FrameworkID>> read = ::protobuf::read<...>(file); ASSERT_SOME(read); ASSERT_EQ(read.get().size(), size); for (...) { EXPECT_EQ(read.get().Get(i), actual.Get(i)); } ``` - Jie Yu On Jan. 21, 2015, 10:23 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30112/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2015, 10:23 a.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > Added `::protobuf::write` -> `::protobuf::read` round-trip test for > `RepeatedPtrField`. > > > Diffs > ----- > > src/tests/protobuf_io_tests.cpp c18bc4f8d342f6a8cbe7ca09fe2bc25f215d8249 > > Diff: https://reviews.apache.org/r/30112/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Michael Park > >
