> On Jan. 23, 2015, 6:04 p.m., Jie Yu wrote: > > src/tests/protobuf_io_tests.cpp, line 157 > > <https://reviews.apache.org/r/30112/diff/3/?file=828922#file828922line157> > > > > No need for this temp variable. > > > > s/read/actual > > > > But this is up to you:)
I do have `read = ::protobuf::read(...)` above, I'd like to keep the symmetry of `write`/`read` and `expected`/`actual`. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30112/#review69421 ----------------------------------------------------------- On Jan. 23, 2015, 6:15 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30112/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2015, 6:15 p.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > Added `::protobuf::write` -> `::protobuf::read` round-trip test for > `RepeatedPtrField`. > > > Diffs > ----- > > src/tests/protobuf_io_tests.cpp c6ce29318b5c310d34ba20a614bdb6398194171b > > Diff: https://reviews.apache.org/r/30112/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Michael Park > >
