----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30112/#review69421 -----------------------------------------------------------
Ship it! src/tests/protobuf_io_tests.cpp <https://reviews.apache.org/r/30112/#comment114112> One more blank line src/tests/protobuf_io_tests.cpp <https://reviews.apache.org/r/30112/#comment114113> No need for this temp variable. s/read/actual But this is up to you:) - Jie Yu On Jan. 21, 2015, 10:32 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30112/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2015, 10:32 p.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > Added `::protobuf::write` -> `::protobuf::read` round-trip test for > `RepeatedPtrField`. > > > Diffs > ----- > > src/tests/protobuf_io_tests.cpp c18bc4f8d342f6a8cbe7ca09fe2bc25f215d8249 > > Diff: https://reviews.apache.org/r/30112/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Michael Park > >
