----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30111/#review69040 -----------------------------------------------------------
Thanks! Much better! 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp <https://reviews.apache.org/r/30111/#comment113605> Mind adjust this comments and move it right above the public 'read' funciton? 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp <https://reviews.apache.org/r/30111/#comment113606> Could you put this helper struct into internal namespace? Also, add a comment saying that this struct is used by the 'read' function below. See comments there for the reason why we need this. 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp <https://reviews.apache.org/r/30111/#comment113607> In the comments, mention that this is a partial specification for RepeatedPtrField. 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp <https://reviews.apache.org/r/30111/#comment113609> Move '{' into a new line. 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp <https://reviews.apache.org/r/30111/#comment113610> We do not do typedef. Please use explicit types. 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp <https://reviews.apache.org/r/30111/#comment113611> ``` if (message.isError()) { return Error(message.error()); } else if (message.isNone()) { break; } else { result.Add()->CopyFrom(message.get()); } ``` 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp <https://reviews.apache.org/r/30111/#comment113612> s/Read T/Read<T> - Jie Yu On Jan. 21, 2015, 10:07 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30111/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2015, 10:07 p.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > Added support for `RepeatedPtrField` to `::protobuf::read`. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp > ff494c3da35a44ada703fa3997d89b4237495ef9 > > Diff: https://reviews.apache.org/r/30111/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Michael Park > >
