> On Jan. 23, 2015, 6 p.m., Jie Yu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp, lines 156-157 > > <https://reviews.apache.org/r/30111/diff/5/?file=828992#file828992line156> > > > > Move this comments to the public read interface. > > Michael Park wrote: > I'm not sure why it should be at the public interface? This comment > regarding "reading a single message", and "first reading the "size" followed > by..." are specific to this version of read. The layout of read is also an > implementation detail that the public interface shouldn't necessarily care > about?
By "layout of the read" I mean the part where we explain the process of reversing `write`: "we read size first and followed by the contents..." - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30111/#review69417 ----------------------------------------------------------- On Jan. 23, 2015, 6:45 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30111/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2015, 6:45 p.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > Added support for `RepeatedPtrField` to `::protobuf::read`. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp > b4f5f172d0ea21fbd56dde1eb43d95f9cddad44b > > Diff: https://reviews.apache.org/r/30111/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Michael Park > >
