----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30111/#review69417 -----------------------------------------------------------
Ship it! LGTM! 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp <https://reviews.apache.org/r/30111/#comment114110> Move this comments to the public read interface. 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp <https://reviews.apache.org/r/30111/#comment114111> s/> >/>>/ 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp <https://reviews.apache.org/r/30111/#comment114108> Could you move these two public interfaces right below the internal Read struct? We usually put relevant code together (no need to worry about multiple internal namespace blocks). - Jie Yu On Jan. 21, 2015, 11:20 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30111/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2015, 11:20 p.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > Added support for `RepeatedPtrField` to `::protobuf::read`. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp > ff494c3da35a44ada703fa3997d89b4237495ef9 > > Diff: https://reviews.apache.org/r/30111/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Michael Park > >
