> On Jan. 20, 2015, 5:48 p.m., Dominic Hamon wrote: > > src/slave/constants.hpp, line 47 > > <https://reviews.apache.org/r/30014/diff/2/?file=824531#file824531line47> > > > > nit: move this down one please so it's added at the end.
Done. > On Jan. 20, 2015, 5:48 p.m., Dominic Hamon wrote: > > src/slave/constants.cpp, line 40 > > <https://reviews.apache.org/r/30014/diff/2/?file=824532#file824532line40> > > > > how did you determine this limit? > > Ritwik Yadav wrote: > I did not calculate or estimate it using any technique. I just thought > that after using up 80% of the available limit, it would be dangerous to > defer garbage collection. That is why I defined a new flag. If you want, I > can change the default value. There is another thing that I can do here. I can simply set the delay as an exponential decay function of the fraction of hard links used. I wonder if any of these solutions would make the problem go away completely. It might reduce the frequency of this particular situational error though. However, I do not understand exactly why the delay was introduced in the first place. Was it to avoid spawning a lot of processes at the same time? - Ritwik ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30014/#review68739 ----------------------------------------------------------- On Jan. 22, 2015, 9:35 p.m., Ritwik Yadav wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30014/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2015, 9:35 p.m.) > > > Review request for mesos, Ben Mahler, Dominic Hamon, and Vinod Kone. > > > Bugs: MESOS-391 > https://issues.apache.org/jira/browse/MESOS-391 > > > Repository: mesos-git > > > Description > ------- > > A fix to enable the slave garbage collector to take the number of hard links > (st_nlinks) into account when creating new directories. > > [UPDATE] - Distributed the changes into two review requests as per > information posted by the Mesos ReviewBot. > > > Diffs > ----- > > src/slave/constants.hpp 761cfafb3b1b342af4d1dbdb2dec39a45dd62794 > src/slave/constants.cpp 83d9fc1cd385722deb31883c17c824fd0e1de8a6 > src/slave/flags.hpp 33a0cb639cd85ce4e03bd4ceaa3fed0834c239b9 > src/slave/slave.cpp fca83b3977b95ddda30f9830da10e124b5c605e6 > > Diff: https://reviews.apache.org/r/30014/diff/ > > > Testing > ------- > > Mesos builds sucessfully and all existing tests pass. > > > Thanks, > > Ritwik Yadav > >
