> On Feb. 4, 2015, 11:55 p.m., Niklas Nielsen wrote: > > src/slave/graceful_shutdown.cpp, line 64 > > <https://reviews.apache.org/r/30580/diff/1/?file=846976#file846976line64> > > > > Maybe this should be a Try<> in the future :)
One step at a time.. :) First thing is we need a check in place for the slave's flag. > On Feb. 4, 2015, 11:55 p.m., Niklas Nielsen wrote: > > src/slave/slave.cpp, line 3226 > > <https://reviews.apache.org/r/30580/diff/1/?file=846977#file846977line3226> > > > > Before the nested timeout notions were: > > > > Containerizer -> Exec -> Executor > > > > Now they are: > > > > Executor -> ExecutorDriver -> CommandExecutor > > > > We should perhaps illustrate this in the figure somehow. For example > > about the timeouts (line 38) Before the nested timeouts were actually Slave -> Executor Driver -> Command Executor, I've only updated the naming and documentation to reflect this. :) I've updated the figure in graceful_shutdown.hpp, is there another figure you're referring to? > On Feb. 4, 2015, 11:55 p.m., Niklas Nielsen wrote: > > src/slave/flags.hpp, lines 133-136 > > <https://reviews.apache.org/r/30580/diff/1/?file=846974#file846974line133> > > > > Could we include that this is the inner most, first and/or the > > effective grace period (taken that we have a hierarchy of graceful > > shutdowns which need this period + delta to allow enough time for each > > step)? Hm, this mentions that this the command executor timeout and the driver/slave use slightly larger timeouts. Do you have a concrete suggestion of how to rephrase this? - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30580/#review71060 ----------------------------------------------------------- On Feb. 4, 2015, 2:14 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30580/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2015, 2:14 a.m.) > > > Review request for mesos, Alexander Rukletsov, Niklas Nielsen, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > This is a pure cleanup to clarify the documentation and naming around > graceful shutdown. > > Note that I also namespaced the methods differently. > > > Diffs > ----- > > src/exec/exec.cpp aada24664dba9060a92230e25689c89852585443 > src/launcher/executor.cpp 1cf28f168cac6e8c7e98686a35509c2b4e052504 > src/slave/constants.hpp 761cfafb3b1b342af4d1dbdb2dec39a45dd62794 > src/slave/flags.hpp 0f6cc41d60a2e3bc2121cc438351135541ef99ba > src/slave/graceful_shutdown.hpp 59f5cfba032a81b5f69c2dd1bc1d96527686127c > src/slave/graceful_shutdown.cpp 04d8f091dfc5a007ac46ccc91c7ff7bfe620b524 > src/slave/slave.cpp a8b262174ab5c9a524db8318d3d1438cd75a702b > src/tests/gc_tests.cpp 454f0974833ad5db8b504a36b010cc72c3a19751 > src/tests/slave_tests.cpp e7e2af63da785644f3f7e6e23607c02be962a2c6 > > Diff: https://reviews.apache.org/r/30580/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
