> On Feb. 6, 2015, 8:44 p.m., Vinod Kone wrote: > > src/exec/exec.cpp, line 736 > > <https://reviews.apache.org/r/30580/diff/1/?file=846971#file846971line736> > > > > mention that you are using the default value?
I tackled these in my subsequent patches already, this initial patch was just a code movement / documentation cleanup. > On Feb. 6, 2015, 8:44 p.m., Vinod Kone wrote: > > src/slave/graceful_shutdown.cpp, line 59 > > <https://reviews.apache.org/r/30580/diff/1/?file=846976#file846976line59> > > > > it is weird that executor driver grace period depends on command > > executor grace period. I agree, this patch is just tackling documentation and naming however. Any concrete suggestions that we can follow up on? - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30580/#review71493 ----------------------------------------------------------- On Feb. 4, 2015, 2:14 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30580/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2015, 2:14 a.m.) > > > Review request for mesos, Alexander Rukletsov, Niklas Nielsen, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > This is a pure cleanup to clarify the documentation and naming around > graceful shutdown. > > Note that I also namespaced the methods differently. > > > Diffs > ----- > > src/exec/exec.cpp aada24664dba9060a92230e25689c89852585443 > src/launcher/executor.cpp 1cf28f168cac6e8c7e98686a35509c2b4e052504 > src/slave/constants.hpp 761cfafb3b1b342af4d1dbdb2dec39a45dd62794 > src/slave/flags.hpp 0f6cc41d60a2e3bc2121cc438351135541ef99ba > src/slave/graceful_shutdown.hpp 59f5cfba032a81b5f69c2dd1bc1d96527686127c > src/slave/graceful_shutdown.cpp 04d8f091dfc5a007ac46ccc91c7ff7bfe620b524 > src/slave/slave.cpp a8b262174ab5c9a524db8318d3d1438cd75a702b > src/tests/gc_tests.cpp 454f0974833ad5db8b504a36b010cc72c3a19751 > src/tests/slave_tests.cpp e7e2af63da785644f3f7e6e23607c02be962a2c6 > > Diff: https://reviews.apache.org/r/30580/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
