----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30792/#review71681 -----------------------------------------------------------
The shared_ptr -> shared_ptr auto case seems good. The make_shared -> shared_ptr auto case seems a tiny bit non-obvious, but I guess it's reasonable for people to understand make_shared. It's going to be fairly uncommon in our code however, since we don't use shared_ptr heavily. I will let benh give the ship it on this one. docs/mesos-c++-style-guide.md <https://reviews.apache.org/r/30792/#comment117546> How about s/nameList/names/ to discourage including type information redundantly in variable names? - Ben Mahler On Feb. 9, 2015, 10:30 a.m., Bernd Mathiske wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30792/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2015, 10:30 a.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > ------- > > Explicitly allows auto declarations for shared pointer creations. Example: > > auto nameList = make_shared<list<string>>(); > > Here the type on the left is already explicitly stated on the right. This > replaces > > shared_ptr<list<string>> nameList = make_shared<list<string>>(); > > where we needlessly write the same type twice. > > > Diffs > ----- > > docs/mesos-c++-style-guide.md b24fe4b64a2577060f66ef49ae8b5d4a9d94167c > > Diff: https://reviews.apache.org/r/30792/diff/ > > > Testing > ------- > > None. This is doc text only. > > > Thanks, > > Bernd Mathiske > >
