> On Feb. 26, 2015, 5:38 p.m., Ben Mahler wrote: > > Is make_shared available in tr1? (stout's memory.hpp still assumes tr1 or > > *full* c++11, so if we support compilers that have partial C++11 features > > this might be a bit confusing: we'd have includes for both <memory> and > > <stout/memory.hpp>).
No, make_shared is not in tr1. And we are not using <boost/make_shared.hpp>. And if we included this, it might get even more confusing with interim step compilers. For now, I will remove make_shared from my proposal. - Bernd ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30792/#review74419 ----------------------------------------------------------- On Feb. 10, 2015, 3:37 a.m., Bernd Mathiske wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30792/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2015, 3:37 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Till Toenshoff, and > Timothy Chen. > > > Repository: mesos > > > Description > ------- > > Explicitly allows auto declarations for shared pointer creations. Example: > > auto nameList = make_shared<list<string>>(); > > Here the type on the left is already explicitly stated on the right. This > replaces > > shared_ptr<list<string>> nameList = make_shared<list<string>>(); > > where we needlessly write the same type twice. > > > Diffs > ----- > > docs/mesos-c++-style-guide.md b24fe4b64a2577060f66ef49ae8b5d4a9d94167c > > Diff: https://reviews.apache.org/r/30792/diff/ > > > Testing > ------- > > None. This is doc text only. > > > Thanks, > > Bernd Mathiske > >
