----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30792/#review71798 -----------------------------------------------------------
Patch looks great! Reviews applied: [30792] All tests passed. - Mesos ReviewBot On Feb. 10, 2015, 11:37 a.m., Bernd Mathiske wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30792/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2015, 11:37 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Till Toenshoff, and > Timothy Chen. > > > Repository: mesos > > > Description > ------- > > Explicitly allows auto declarations for shared pointer creations. Example: > > auto nameList = make_shared<list<string>>(); > > Here the type on the left is already explicitly stated on the right. This > replaces > > shared_ptr<list<string>> nameList = make_shared<list<string>>(); > > where we needlessly write the same type twice. > > > Diffs > ----- > > docs/mesos-c++-style-guide.md b24fe4b64a2577060f66ef49ae8b5d4a9d94167c > > Diff: https://reviews.apache.org/r/30792/diff/ > > > Testing > ------- > > None. This is doc text only. > > > Thanks, > > Bernd Mathiske > >