> On Feb. 11, 2015, 2:16 a.m., Ben Mahler wrote: > > src/tests/mesos.cpp, line 238 > > <https://reviews.apache.org/r/30850/diff/1/?file=860554#file860554line238> > > > > Can you pull out the removal of 'process::' and just commit it as a > > patch on master?
Done. > On Feb. 11, 2015, 2:16 a.m., Ben Mahler wrote: > > src/slave/slave.cpp, lines 3537-3541 > > <https://reviews.apache.org/r/30850/diff/1/?file=860552#file860552line3537> > > > > Is this stringify going to capture all of the disk information or do > > you want a JSON representation? I am leaning toward making stringify(resources) print a JSON. What do you think? - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30850/#review71895 ----------------------------------------------------------- On Feb. 10, 2015, 11:10 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30850/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2015, 11:10 p.m.) > > > Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Added validation for checkpointed resources during slave recovery. > > This is a rebased version for https://reviews.apache.org/r/29913/ > > > Diffs > ----- > > src/slave/slave.hpp 35c7c8bf6eb8efee332c13713f6087c6f899d6e3 > src/slave/slave.cpp 7a29f86bf873141759957a6ef5502f6a3b6ab269 > src/tests/mesos.hpp 83a369968ab2403fa341829ac5d11f7243095190 > src/tests/mesos.cpp 21a405366f56c963611324076efe775f85b9d9f7 > src/tests/persistent_volume_tests.cpp > e3a8d33b6ae2b6afe5f4ab7c029b2f37a861f112 > > Diff: https://reviews.apache.org/r/30850/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
