> On Feb. 11, 2015, 2:16 a.m., Ben Mahler wrote: > > src/slave/slave.cpp, lines 3537-3541 > > <https://reviews.apache.org/r/30850/diff/1/?file=860552#file860552line3537> > > > > Is this stringify going to capture all of the disk information or do > > you want a JSON representation? > > Jie Yu wrote: > I am leaning toward making stringify(resources) print a JSON. What do you > think?
This has come up in other places as well, I think making `stringify`/`parse` print/read `JSON` would be where we want to head rather than trying to come up with our own syntax to augment `name(role):value`. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30850/#review71895 ----------------------------------------------------------- On Feb. 11, 2015, 6:38 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30850/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2015, 6:38 p.m.) > > > Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Added validation for checkpointed resources during slave recovery. > > This is a rebased version for https://reviews.apache.org/r/29913/ > > > Diffs > ----- > > src/slave/slave.hpp 7a399f6df50c69b7e1e12d74f076fa57b6edb1b3 > src/slave/slave.cpp f39a876cdd6b580a7a75fd053e6923761bee7635 > src/tests/mesos.hpp 2b0c90d166ed33065f2a4a2909c61cc5119da511 > src/tests/mesos.cpp ac2dc737eff48d122cfd604d4820f423e5bc0472 > src/tests/persistent_volume_tests.cpp > b4f2298069233b27f6b4b8d668753810f43bb58d > > Diff: https://reviews.apache.org/r/30850/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
