-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30958/#review72312
-----------------------------------------------------------



src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/30958/#comment118396>

    Unless I am on a wrong tree, why do you create this ingress qdisc again 
since we already do it in create()? Even if we really need it, you don't 
mention in subject or changelog.


- Cong Wang


On Feb. 13, 2015, 12:48 a.m., Chi Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30958/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2015, 12:48 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Cong Wang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> PortMappingIsolator: Remove ingress qdiscs on eth0 and lo after the last 
> container exits.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 
> b860b17e59486cd6097183a4d3139fbd5c897b44 
> 
> Diff: https://reviews.apache.org/r/30958/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>

Reply via email to