> On Feb. 13, 2015, 2:14 a.m., Cong Wang wrote: > > src/slave/containerizer/isolators/network/port_mapping.cpp, line 1622 > > <https://reviews.apache.org/r/30958/diff/1/?file=862684#file862684line1622> > > > > Unless I am on a wrong tree, why do you create this ingress qdisc again > > since we already do it in create()? Even if we really need it, you don't > > mention in subject or changelog. > > Chi Zhang wrote: > This code is the same as the one in create. If an ingress qdisc already > exists, Try will return a some, which is false. Since we only check if Try is > an error, we should be fine. This is basically doing 'add them back if none > exist now'.
I know. So in which case it is "none exist now"? And why do you add it in a patch with this $subject? IOW, why you add some code but hide it in changelog? - Cong ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30958/#review72312 ----------------------------------------------------------- On Feb. 13, 2015, 12:48 a.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30958/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2015, 12:48 a.m.) > > > Review request for mesos, Jie Yu and Cong Wang. > > > Repository: mesos > > > Description > ------- > > PortMappingIsolator: Remove ingress qdiscs on eth0 and lo after the last > container exits. > > > Diffs > ----- > > src/slave/containerizer/isolators/network/port_mapping.cpp > b860b17e59486cd6097183a4d3139fbd5c897b44 > > Diff: https://reviews.apache.org/r/30958/diff/ > > > Testing > ------- > > > Thanks, > > Chi Zhang > >
