----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30958/#review72315 -----------------------------------------------------------
src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/30958/#comment118398> This code is the same as the one in create. If an ingress qdisc already exists, Try will return a some, which is false. Since we only check if Try is an error, we should be fine. This is basically doing 'add them back if none exist now'. - Chi Zhang On Feb. 13, 2015, 12:48 a.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30958/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2015, 12:48 a.m.) > > > Review request for mesos, Jie Yu and Cong Wang. > > > Repository: mesos > > > Description > ------- > > PortMappingIsolator: Remove ingress qdiscs on eth0 and lo after the last > container exits. > > > Diffs > ----- > > src/slave/containerizer/isolators/network/port_mapping.cpp > b860b17e59486cd6097183a4d3139fbd5c897b44 > > Diff: https://reviews.apache.org/r/30958/diff/ > > > Testing > ------- > > > Thanks, > > Chi Zhang > >
