> On Feb. 17, 2015, 6:39 p.m., Zameer Manji wrote:
> > Would it be possible to handle all default values in all protobufs in a
> > generic manner? For example the 'role' field of FrameworkInfo has the same
> > problem:
> > https://github.com/apache/mesos/blob/1efdf1d69373cca7903bc06847f1c44a91383032/include/mesos/mesos.proto#L128
Actually that would be awesome, but so far I did not find generic way. Also
when looking at the actual comparison code comparing the messages it did not
occur to often. For example the FrameworkInfo you mentioned has a very simple
comparison not considering the roles:
inline bool operator == (const FrameworkInfo& left, const FrameworkInfo&
right)
{
return (left.name() == right.name()) && (left.user() == right.user());
}
- Joerg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31011/#review72753
-----------------------------------------------------------
On Feb. 17, 2015, 12:58 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31011/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2015, 12:58 p.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-2309
> https://issues.apache.org/jira/browse/MESOS-2309
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Changed comparison for CommandInfo to consider shell default value.
>
>
> Diffs
> -----
>
> src/common/type_utils.cpp 12a36bbd7d7773b25dedf2d0d951c79e0b5141d6
>
> Diff: https://reviews.apache.org/r/31011/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>
