----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31011/#review73663 -----------------------------------------------------------
src/common/type_utils.cpp <https://reviews.apache.org/r/31011/#comment120059> Does the reflection API support getting default values? (possibly workable w/o direct default support) Does comparing the serialization of two messages compensate for defaults? (I doubt it). I want to make sure we're not setting ourselves up to have to write these manual equality checkers for all of our protobufs instead of using generic reflection or serialization based equality. What's the plan? - Ben Mahler On Feb. 18, 2015, 11:32 a.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31011/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2015, 11:32 a.m.) > > > Review request for mesos and Till Toenshoff. > > > Bugs: MESOS-2309 > https://issues.apache.org/jira/browse/MESOS-2309 > > > Repository: mesos > > > Description > ------- > > Changed comparison for CommandInfo to consider shell default value. > > > Diffs > ----- > > src/common/type_utils.cpp 12a36bbd7d7773b25dedf2d0d951c79e0b5141d6 > > Diff: https://reviews.apache.org/r/31011/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joerg Schad > >
