----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31011/#review73552 -----------------------------------------------------------
Ship it! Thanks Joerg. Would it make sense to follow up with a test? - Till Toenshoff On Feb. 18, 2015, 11:32 a.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31011/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2015, 11:32 a.m.) > > > Review request for mesos and Till Toenshoff. > > > Bugs: MESOS-2309 > https://issues.apache.org/jira/browse/MESOS-2309 > > > Repository: mesos > > > Description > ------- > > Changed comparison for CommandInfo to consider shell default value. > > > Diffs > ----- > > src/common/type_utils.cpp 12a36bbd7d7773b25dedf2d0d951c79e0b5141d6 > > Diff: https://reviews.apache.org/r/31011/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joerg Schad > >
