----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30074/#review72957 -----------------------------------------------------------
Patch looks great! Reviews applied: [30074] All tests passed. - Mesos ReviewBot On Feb. 18, 2015, 10:36 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30074/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2015, 10:36 a.m.) > > > Review request for mesos, Niklas Nielsen and Till Toenshoff. > > > Bugs: mesos-2229 > https://issues.apache.org/jira/browse/mesos-2229 > > > Repository: mesos > > > Description > ------- > > Adds and entry `max_allowed_age_secs` to the response of the `state.json` > endpoint in the slave. > > The max allowed age value is available only if it is set, which depends on > the flag `--disk_watch_interval` which by default runs every minute (So it > will only be available after the first minute running). > > Modifies the unit test `SlaveTest.StateEndpoint` so it takes into account the > new entry. > > > Diffs > ----- > > src/slave/http.cpp ef6e64882282a9d7be252ccdc545ab96d6323c3b > src/slave/slave.hpp 7a399f6df50c69b7e1e12d74f076fa57b6edb1b3 > src/slave/slave.cpp ec7ec1356e745bb07484ae1755c9183b038043b3 > src/tests/slave_tests.cpp 21709e2858d91a2746e0343786f73dec22735da6 > > Diff: https://reviews.apache.org/r/30074/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
