----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30074/#review73003 -----------------------------------------------------------
The patch changed a bit since the first /state.json version. Holding back on the first given ship-it until we get the new version into a good shape src/slave/slave.cpp <https://reviews.apache.org/r/30074/#comment119130> How about replacing age(usage.get()) here as well? src/slave/slave.cpp <https://reviews.apache.org/r/30074/#comment119129> Can you help me understand the second part of this. What does 'as if ... were using no disk'? Think we need to sharpen this comment a little bit src/slave/slave.cpp <https://reviews.apache.org/r/30074/#comment119132> Max age of 0 seconds is hard to tell whether is a very unhealthy system or "no value present". Wonder if we should leave a todo if the metrics system doesn't support it. - Niklas Nielsen On Feb. 18, 2015, 7:09 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30074/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2015, 7:09 a.m.) > > > Review request for mesos, Niklas Nielsen and Till Toenshoff. > > > Bugs: mesos-2229 > https://issues.apache.org/jira/browse/mesos-2229 > > > Repository: mesos > > > Description > ------- > > Adds and entry `max_allowed_age_secs` to the response of the `state.json` > endpoint in the slave. > > The max allowed age value is available only if it is set, which depends on > the flag `--disk_watch_interval` which by default runs every minute (So it > will only be available after the first minute running). > > Modifies the unit test `SlaveTest.StateEndpoint` so it takes into account the > new entry. > > > Diffs > ----- > > src/slave/metrics.hpp e2ce845ec2229e1e6e71c710022551bec9d15029 > src/slave/metrics.cpp ee610b8a7d352c20e8a91bb86c8aa2c1f011e910 > src/slave/slave.hpp 7a399f6df50c69b7e1e12d74f076fa57b6edb1b3 > src/slave/slave.cpp ec7ec1356e745bb07484ae1755c9183b038043b3 > src/tests/slave_tests.cpp 21709e2858d91a2746e0343786f73dec22735da6 > > Diff: https://reviews.apache.org/r/30074/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
