> On Feb. 18, 2015, 9:16 p.m., Niklas Nielsen wrote: > > src/slave/slave.cpp, line 3855 > > <https://reviews.apache.org/r/30074/diff/8/?file=867823#file867823line3855> > > > > Max age of 0 seconds is hard to tell whether is a very unhealthy system > > or "no value present". Wonder if we should leave a todo if the metrics > > system doesn't support it. > > Alexander Rukletsov wrote: > Observing the new approach, I would like to circle back with my autistic > suggestion: shall we introduce a sane default for > `executorDirectoryMaxAllowedAge` and do not make it optional? > > Alexander Rojas wrote: > Actually, now we need it, because `metrics` requires it. I though > age(0).secs() would be a good default value, but it is open to sugestions. > > Alexander Rukletsov wrote: > It looks like we do not use optional fields in Metric structures, hence a > default is probably a good option. How about `Flags::gc_delay`?
That one sounds good too. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30074/#review73003 ----------------------------------------------------------- On Feb. 18, 2015, 4:09 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30074/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2015, 4:09 p.m.) > > > Review request for mesos, Niklas Nielsen and Till Toenshoff. > > > Bugs: mesos-2229 > https://issues.apache.org/jira/browse/mesos-2229 > > > Repository: mesos > > > Description > ------- > > Adds and entry `max_allowed_age_secs` to the response of the `state.json` > endpoint in the slave. > > The max allowed age value is available only if it is set, which depends on > the flag `--disk_watch_interval` which by default runs every minute (So it > will only be available after the first minute running). > > Modifies the unit test `SlaveTest.StateEndpoint` so it takes into account the > new entry. > > > Diffs > ----- > > src/slave/metrics.hpp e2ce845ec2229e1e6e71c710022551bec9d15029 > src/slave/metrics.cpp ee610b8a7d352c20e8a91bb86c8aa2c1f011e910 > src/slave/slave.hpp 7a399f6df50c69b7e1e12d74f076fa57b6edb1b3 > src/slave/slave.cpp ec7ec1356e745bb07484ae1755c9183b038043b3 > src/tests/slave_tests.cpp 21709e2858d91a2746e0343786f73dec22735da6 > > Diff: https://reviews.apache.org/r/30074/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
