----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30961/#review73129 -----------------------------------------------------------
src/tests/hook_tests.cpp <https://reviews.apache.org/r/30961/#comment119360> Looks like we can just call this `label` rather than `label1`? src/tests/hook_tests.cpp <https://reviews.apache.org/r/30961/#comment119361> Seems like we could simplify this to something like: ```cpp const Labels &labels = taskInfo.get().labels(); ASSERT_EQ(1, labels.labels_size()); EXPECT_EQ(labels.labels().Get(0).key(), testLabelKey); ``` - Michael Park On Feb. 13, 2015, 11:28 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30961/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2015, 11:28 p.m.) > > > Review request for mesos, Ben Mahler and Kapil Arya. > > > Bugs: MESOS-2351 > https://issues.apache.org/jira/browse/MESOS-2351 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/hook.hpp d83ace576a2c78eb7b1e910d89d912f6df5c46ef > src/examples/test_hook_module.cpp 8faf6850aafcebda7e9f0d1b735d61f7effa842d > src/hook/manager.cpp a6938d09851898dd5853d86231c9f9d9db15729b > src/master/master.cpp f10a3cffdb0b9831b2b8af0dfd30f73d1d8ed937 > src/tests/hook_tests.cpp dc6d289394e5718a37936e29ad6d988b52933f98 > > Diff: https://reviews.apache.org/r/30961/diff/ > > > Testing > ------- > > make check (with modified VerifyMasterLaunchTaskHook test) > > > Thanks, > > Niklas Nielsen > >
