----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31016/#review73203 -----------------------------------------------------------
src/hook/manager.cpp <https://reviews.apache.org/r/31016/#comment119441> Same as my comment on [r30961](https://reviews.apache.org/r/30961/#comment119359), I think it should be `s/taskInfo/taskInfo_/`. src/hook/manager.cpp <https://reviews.apache.org/r/31016/#comment119442> Is this different than `labels->CopyFrom(result.get());?` src/slave/slave.hpp <https://reviews.apache.org/r/31016/#comment119444> This semi-colon belongs in [r31027](https://reviews.apache.org/r/31027/). - Michael Park On Feb. 13, 2015, 11:28 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31016/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2015, 11:28 p.m.) > > > Review request for mesos, Ben Mahler and Kapil Arya. > > > Repository: mesos > > > Description > ------- > > Added decorator which gets invoked on start of runTask() sequence in the > slave. > > > Diffs > ----- > > include/mesos/hook.hpp d83ace576a2c78eb7b1e910d89d912f6df5c46ef > src/hook/manager.hpp a6594c180e772beccaf5beeaafc5cc02f69621a4 > src/hook/manager.cpp a6938d09851898dd5853d86231c9f9d9db15729b > src/slave/slave.hpp 7a399f6df50c69b7e1e12d74f076fa57b6edb1b3 > src/slave/slave.cpp ec7ec1356e745bb07484ae1755c9183b038043b3 > > Diff: https://reviews.apache.org/r/31016/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Niklas Nielsen > >
