> On Feb. 19, 2015, 2:47 a.m., Ben Mahler wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, lines 409-420 > > <https://reviews.apache.org/r/30015/diff/3/?file=864816#file864816line409> > > > > This is a bit tricky, you are returning -1 to capture "no limit". Why > > not return a Result and document that None() means no limit?
As suggested, I will introduce os::pathconf in a separate patch. - Ritwik ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30015/#review73076 ----------------------------------------------------------- On Feb. 22, 2015, 6:26 a.m., Ritwik Yadav wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30015/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2015, 6:26 a.m.) > > > Review request for mesos, Ben Mahler, Dominic Hamon, and Vinod Kone. > > > Bugs: MESOS-391 > https://issues.apache.org/jira/browse/MESOS-391 > > > Repository: mesos > > > Description > ------- > > Adding methods to fetch the number of hard links associated with a path as > well as the limit. > It uses the lstat and pathconf system calls to get these two numbers > respectively. > This will help the garbage collector of the slave process to take the number > of hard links into account when scheduling a directory for garbage collection. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 8a4fda97ee29c185471a69f60803efc193cbe922 > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > 8a2d445c2edaa70da0e7b50e14ef88b2d9224a16 > > Diff: https://reviews.apache.org/r/30015/diff/ > > > Testing > ------- > > Build succeeds. > > > Thanks, > > Ritwik Yadav > >
