> On Feb. 14, 2015, midnight, Ben Mahler wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, lines 411-435 > > <https://reviews.apache.org/r/30015/diff/2/?file=830289#file830289line411> > > > > It looks like it's time to introduce `os::lstat` and `os::pathconf`, > > instead of introducing a new function for every variable in `stat` and > > `pathconf`. Mind updating this review accordingly? > > > > Also, mind adding a test inside os_tests.cpp?
I have introduced os::lstat and os::pathconf wrappers inside os.hpp. I also wrote a test for counting the number of links. I would do the migration related stuff in the next patch. - Ritwik ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30015/#review72456 ----------------------------------------------------------- On Feb. 16, 2015, 8:42 a.m., Ritwik Yadav wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30015/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2015, 8:42 a.m.) > > > Review request for mesos, Ben Mahler, Dominic Hamon, and Vinod Kone. > > > Bugs: MESOS-391 > https://issues.apache.org/jira/browse/MESOS-391 > > > Repository: mesos > > > Description > ------- > > Adding methods to fetch the number of hard links associated with a path as > well as the limit. > It uses the lstat and pathconf system calls to get these two numbers > respectively. > This will help the garbage collector of the slave process to take the number > of hard links into account when scheduling a directory for garbage collection. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 8a4fda97ee29c185471a69f60803efc193cbe922 > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > 8a2d445c2edaa70da0e7b50e14ef88b2d9224a16 > > Diff: https://reviews.apache.org/r/30015/diff/ > > > Testing > ------- > > Build succeeds. > > > Thanks, > > Ritwik Yadav > >
