----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30015/#review72456 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp <https://reviews.apache.org/r/30015/#comment118524> It looks like it's time to introduce `os::lstat` and `os::pathconf`, instead of introducing a new function for every variable in `stat` and `pathconf`. Mind updating this review accordingly? Also, mind adding a test inside os_tests.cpp? - Ben Mahler On Jan. 22, 2015, 8:48 p.m., Ritwik Yadav wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30015/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2015, 8:48 p.m.) > > > Review request for mesos, Ben Mahler, Dominic Hamon, and Vinod Kone. > > > Bugs: MESOS-391 > https://issues.apache.org/jira/browse/MESOS-391 > > > Repository: mesos > > > Description > ------- > > Adding methods to fetch the number of hard links associated with a path as > well as the limit. > It uses the lstat and pathconf system calls to get these two numbers > respectively. > This will help the garbage collector of the slave process to take the number > of hard links into account when scheduling a directory for garbage collection. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 0446f6a5d5628f8566d4cbaf33dee29b52c3c42e > > Diff: https://reviews.apache.org/r/30015/diff/ > > > Testing > ------- > > Build succeeds. > > > Thanks, > > Ritwik Yadav > >
