----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31227/#review73532 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp <https://reviews.apache.org/r/31227/#comment119932> The placement of & is inconsitent to other lines in this file (string& str vs string &str). The Google Style Guide seems to prefere your solution but what is our take on this? Would it make sense to add some tests? - Joerg Schad On Feb. 20, 2015, 4:01 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31227/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2015, 4:01 p.m.) > > > Review request for mesos, Joerg Schad, Niklas Nielsen, and Till Toenshoff. > > > Bugs: MESOS-2333 > https://issues.apache.org/jira/browse/MESOS-2333 > > > Repository: mesos > > > Description > ------- > > Adds a function `wildcardMatching` which takes a string to be match and a > pattern and returns true if the string matches the pattern. > > The patter is a string where the special characters '*' and '?' are usind as > wildcards. '*' is used as "any character, zero or more times" while '?' is > used as "any character exactly once". > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp > 46b79bc5c11cb1878ffccb4c0c8bb8a49ee9832d > > Diff: https://reviews.apache.org/r/31227/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
