----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31227/#review73778 -----------------------------------------------------------
after fixing the issues lgtm! 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp <https://reviews.apache.org/r/31227/#comment120184> // "x" matches "*". 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp <https://reviews.apache.org/r/31227/#comment120183> mismatch 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp <https://reviews.apache.org/r/31227/#comment120185> . 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp <https://reviews.apache.org/r/31227/#comment120186> . 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp <https://reviews.apache.org/r/31227/#comment120187> . 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp <https://reviews.apache.org/r/31227/#comment120188> . 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp <https://reviews.apache.org/r/31227/#comment120189> . 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp <https://reviews.apache.org/r/31227/#comment120190> Header comment for Testcase. 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp <https://reviews.apache.org/r/31227/#comment120182> same - Joerg Schad On Feb. 23, 2015, 4:56 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31227/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2015, 4:56 p.m.) > > > Review request for mesos, Joerg Schad, Niklas Nielsen, and Till Toenshoff. > > > Bugs: MESOS-2333 > https://issues.apache.org/jira/browse/MESOS-2333 > > > Repository: mesos > > > Description > ------- > > Adds a function `wildcardMatching` which takes a string to be match and a > pattern and returns true if the string matches the pattern. > > The patter is a string where the special characters '*' and '?' are usind as > wildcards. '*' is used as "any character, zero or more times" while '?' is > used as "any character exactly once". > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp > 46b79bc5c11cb1878ffccb4c0c8bb8a49ee9832d > 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp > b90057972d22123d655697425581cc2767ec825d > > Diff: https://reviews.apache.org/r/31227/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
