----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31250/#review75026 -----------------------------------------------------------
src/slave/containerizer/isolators/cgroups/cpushare.cpp <https://reviews.apache.org/r/31250/#comment121957> Can you add a slave flag so that we can turn it off if needed? - Jie Yu On March 3, 2015, 7:37 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31250/ > ----------------------------------------------------------- > > (Updated March 3, 2015, 7:37 p.m.) > > > Review request for mesos and Ian Downes. > > > Bugs: mesos-2103 > https://issues.apache.org/jira/browse/mesos-2103 > > > Repository: mesos > > > Description > ------- > > Ian, as discussed, I put the logic in cpu isolator for now until linux > launcher sees more and more need to report isolator-independent cgroup usage. > > > Diffs > ----- > > include/mesos/mesos.proto 9df972d750ce1e4a81d2e96cc508d6f83cad2fc8 > src/slave/containerizer/isolators/cgroups/cpushare.cpp > d4967687241ddf50a85beb961d691a8974f24fea > src/tests/isolator_tests.cpp f7323965b94543bfda78afc4f60fc677f4900ecd > > Diff: https://reviews.apache.org/r/31250/diff/ > > > Testing > ------- > > added a new test. the test is end-to-end so that future replacement of the > actual logic won't require a change. > > > Thanks, > > Chi Zhang > >
