> On March 6, 2015, 5:03 p.m., Dominic Hamon wrote: > > src/slave/flags.hpp, line 229 > > <https://reviews.apache.org/r/31250/diff/5/?file=886975#file886975line229> > > > > having this in slave makes me uncomfortable. it really should be > > somewhere like the isolator given that it's accessed only there. > > Chi Zhang wrote: > I agree. with slave getting bigger and bigger, we are gonna have all > these minor feature flags in there. So far this is the only portal for slave > flags.
I agree as well. Right now, we use the prefix `cgroups` to indicate that it's a cgroups isolator related flag. Ideally, if our flag parsing can have similar grouping and subcommand features in argparse of Python, that'll be awesome. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31250/#review73835 ----------------------------------------------------------- On March 6, 2015, 6:36 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31250/ > ----------------------------------------------------------- > > (Updated March 6, 2015, 6:36 p.m.) > > > Review request for mesos and Ian Downes. > > > Bugs: mesos-2103 > https://issues.apache.org/jira/browse/mesos-2103 > > > Repository: mesos > > > Description > ------- > > Expose the number of processes and threads in a container when cgroup is > enabled. > > > Diffs > ----- > > include/mesos/mesos.proto 9df972d750ce1e4a81d2e96cc508d6f83cad2fc8 > src/slave/containerizer/isolators/cgroups/cpushare.cpp > d4967687241ddf50a85beb961d691a8974f24fea > src/slave/flags.hpp 56b25caf3901b38bdecb50310e8bcae0b114efa8 > src/tests/isolator_tests.cpp f7323965b94543bfda78afc4f60fc677f4900ecd > > Diff: https://reviews.apache.org/r/31250/diff/ > > > Testing > ------- > > > Thanks, > > Chi Zhang > >
