> On March 6, 2015, 5:03 p.m., Dominic Hamon wrote: > > src/tests/isolator_tests.cpp, line 577 > > <https://reviews.apache.org/r/31250/diff/2/?file=873351#file873351line577> > > > > 0U .. processes() and threads() are unsigned.
fixed. > On March 6, 2015, 5:03 p.m., Dominic Hamon wrote: > > src/tests/isolator_tests.cpp, line 583 > > <https://reviews.apache.org/r/31250/diff/2/?file=873351#file873351line583> > > > > vector<string> argv{"sh", "-c", "sleep 1000"}; > > > > initializer lists! kept the old way to remain consistent with rest of the file. Will keep a note on this for 'fresh' files. > On March 6, 2015, 5:03 p.m., Dominic Hamon wrote: > > src/tests/isolator_tests.cpp, line 586 > > <https://reviews.apache.org/r/31250/diff/2/?file=873351#file873351line586> > > > > this is flaky. what if the below takes longer than expected? or someone > > thinks that changing this value to be smaller will speed up the test? > > > > maybe 'while true; do sleep 1s; done;' is better? fixed. thanks for the suggestion. > On March 6, 2015, 5:03 p.m., Dominic Hamon wrote: > > src/tests/isolator_tests.cpp, line 602 > > <https://reviews.apache.org/r/31250/diff/2/?file=873351#file873351line602> > > > > s/> >/>>/ throughout. fixed. > On March 6, 2015, 5:03 p.m., Dominic Hamon wrote: > > src/slave/flags.hpp, line 229 > > <https://reviews.apache.org/r/31250/diff/5/?file=886975#file886975line229> > > > > having this in slave makes me uncomfortable. it really should be > > somewhere like the isolator given that it's accessed only there. I agree. with slave getting bigger and bigger, we are gonna have all these minor feature flags in there. So far this is the only portal for slave flags. - Chi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31250/#review73835 ----------------------------------------------------------- On March 6, 2015, 6:36 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31250/ > ----------------------------------------------------------- > > (Updated March 6, 2015, 6:36 p.m.) > > > Review request for mesos and Ian Downes. > > > Bugs: mesos-2103 > https://issues.apache.org/jira/browse/mesos-2103 > > > Repository: mesos > > > Description > ------- > > Expose the number of processes and threads in a container when cgroup is > enabled. > > > Diffs > ----- > > include/mesos/mesos.proto 9df972d750ce1e4a81d2e96cc508d6f83cad2fc8 > src/slave/containerizer/isolators/cgroups/cpushare.cpp > d4967687241ddf50a85beb961d691a8974f24fea > src/slave/flags.hpp 56b25caf3901b38bdecb50310e8bcae0b114efa8 > src/tests/isolator_tests.cpp f7323965b94543bfda78afc4f60fc677f4900ecd > > Diff: https://reviews.apache.org/r/31250/diff/ > > > Testing > ------- > > > Thanks, > > Chi Zhang > >
