----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31897/#review75946 -----------------------------------------------------------
src/linux/fs.hpp <https://reviews.apache.org/r/31897/#comment123279> Looks like this constructor is not used. Kill it? src/linux/fs.hpp <https://reviews.apache.org/r/31897/#comment123275> Can you align all the `mountinfo[x]:`? src/linux/fs.cpp <https://reviews.apache.org/r/31897/#comment123277> This is cpp file. Please remove all std:: prefix and add `using std::string` above. src/linux/fs.cpp <https://reviews.apache.org/r/31897/#comment123284> ``` return Error("Mount ID is not a number") ``` src/linux/fs.cpp <https://reviews.apache.org/r/31897/#comment123286> Ditto. ``` Parent ID is not a number. ``` src/linux/fs.cpp <https://reviews.apache.org/r/31897/#comment123287> ``` return Error("Invalid device number") ``` src/linux/fs.cpp <https://reviews.apache.org/r/31897/#comment123288> ``` return Error("Device major is not a number"); ``` src/linux/fs.cpp <https://reviews.apache.org/r/31897/#comment123289> ``` return Error("Device minor is not a number"); ``` src/linux/fs.cpp <https://reviews.apache.org/r/31897/#comment123291> Can you verify it by checking the kernel source code? - Jie Yu On March 10, 2015, 5:22 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31897/ > ----------------------------------------------------------- > > (Updated March 10, 2015, 5:22 p.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Entries in this table include information on mount propagation. > > > Diffs > ----- > > src/linux/fs.hpp ac8b5f416dae0a9388a3839b6f078abdcd42edae > src/linux/fs.cpp b01d14c3a1b296566b2b17a7f540097bd7cc53dd > src/tests/fs_tests.cpp 39d212f6271c0b108f08562e3f0e8710d7165aa7 > > Diff: https://reviews.apache.org/r/31897/diff/ > > > Testing > ------- > > Added two tests to verify the parsing. > > > Thanks, > > Ian Downes > >
