> On March 10, 2015, 1:05 p.m., Timothy Chen wrote: > > src/linux/fs.hpp, line 81 > > <https://reviews.apache.org/r/31897/diff/1/?file=890350#file890350line81> > > > > space?
Quoted to make it clear there's no space for options, both when reported and when used. > On March 10, 2015, 1:05 p.m., Timothy Chen wrote: > > src/linux/fs.cpp, line 83 > > <https://reviews.apache.org/r/31897/diff/1/?file=890351#file890351line83> > > > > log error? As in LOG()? I added more detail to the message, following Jie's comments above, but don't think we should actually LOG here, that should be done by the caller. > On March 10, 2015, 1:05 p.m., Timothy Chen wrote: > > src/tests/fs_tests.cpp, line 137 > > <https://reviews.apache.org/r/31897/diff/1/?file=890352#file890352line137> > > > > Is this test filtered to run only on Linux? Yes, Linux specific test sources are conditionally built in the Makefile. if OS_LINUX mesos_tests_SOURCES += tests/cgroups_isolator_tests.cpp mesos_tests_SOURCES += tests/cgroups_tests.cpp mesos_tests_SOURCES += tests/fs_tests.cpp mesos_tests_SOURCES += tests/ns_tests.cpp mesos_tests_SOURCES += tests/perf_tests.cpp mesos_tests_SOURCES += tests/setns_test_helper.cpp endif - Ian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31897/#review75945 ----------------------------------------------------------- On March 10, 2015, 10:22 a.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31897/ > ----------------------------------------------------------- > > (Updated March 10, 2015, 10:22 a.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Entries in this table include information on mount propagation. > > > Diffs > ----- > > src/linux/fs.hpp ac8b5f416dae0a9388a3839b6f078abdcd42edae > src/linux/fs.cpp b01d14c3a1b296566b2b17a7f540097bd7cc53dd > src/tests/fs_tests.cpp 39d212f6271c0b108f08562e3f0e8710d7165aa7 > > Diff: https://reviews.apache.org/r/31897/diff/ > > > Testing > ------- > > Added two tests to verify the parsing. > > > Thanks, > > Ian Downes > >
