> On March 10, 2015, 8:05 p.m., Timothy Chen wrote: > > src/linux/fs.cpp, line 83 > > <https://reviews.apache.org/r/31897/diff/1/?file=890351#file890351line83> > > > > log error? > > Ian Downes wrote: > As in LOG()? I added more detail to the message, following Jie's comments > above, but don't think we should actually LOG here, that should be done by > the caller.
Sorry I meant to log out the error returned from Try, exactly what Jie suggested (didn't see his updates while I was commenting). - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31897/#review75945 ----------------------------------------------------------- On March 10, 2015, 5:22 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31897/ > ----------------------------------------------------------- > > (Updated March 10, 2015, 5:22 p.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Entries in this table include information on mount propagation. > > > Diffs > ----- > > src/linux/fs.hpp ac8b5f416dae0a9388a3839b6f078abdcd42edae > src/linux/fs.cpp b01d14c3a1b296566b2b17a7f540097bd7cc53dd > src/tests/fs_tests.cpp 39d212f6271c0b108f08562e3f0e8710d7165aa7 > > Diff: https://reviews.apache.org/r/31897/diff/ > > > Testing > ------- > > Added two tests to verify the parsing. > > > Thanks, > > Ian Downes > >
