Github user kaspersorensen commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/156#discussion_r132087025
  
    --- Diff: style/checkstyle.xml ---
    @@ -18,29 +18,47 @@ specific language governing permissions and limitations
     under the License.
     -->
     <!DOCTYPE module PUBLIC
    -    "-//Puppy Crawl//DTD Check Configuration 1.2//EN"
    -    "http://www.puppycrawl.com/dtds/configuration_1_2.dtd";>
    +        "-//Puppy Crawl//DTD Check Configuration 1.2//EN"
    +        "http://www.puppycrawl.com/dtds/configuration_1_2.dtd";>
     
     <module name="Checker">
    -   <module name="SuppressionFilter">
    -    <property name="file" value="style/checkstyle_suppressions.xml"/>
    -   </module>
    +    <module name="SuppressionFilter">
    +        <property name="file" value="style/checkstyle_suppressions.xml"/>
    +    </module>
     
    -   <module name="Header">
    -       <property name="headerFile" value="style/licence_header.txt"/>
    -       <property name="fileExtensions" value="java"/>
    -   </module>
    +    <module name="Header">
    +        <property name="headerFile" value="style/licence_header.txt"/>
    +        <property name="fileExtensions" value="java"/>
    +    </module>
    +    
    +    <module name="FileTabCharacter">
    --- End diff --
    
    Cool, but now the build fails then so somehow we need to fix it. Either you 
go ahead and fix it (you certainly have my blessing) or we comment out this 
rule and make it a separate issue to fix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to