arjansh commented on a change in pull request #230: dev/add datatypes to excel
columns
URL: https://github.com/apache/metamodel/pull/230#discussion_r330054372
##########
File path:
excel/src/test/java/org/apache/metamodel/excel/ExcelDataContextTest.java
##########
@@ -402,10 +402,10 @@ public void testMissingValues() throws Exception {
assertEquals(2, schema.getTableCount());
Table table = schema.getTables().get(0);
-
assertEquals("[Column[name=a,columnNumber=0,type=VARCHAR,nullable=true,nativeType=null,columnSize=null],
"
+
assertEquals("[Column[name=a,columnNumber=0,type=INTEGER,nullable=true,nativeType=null,columnSize=null],
"
Review comment:
For backwards compatibility reasons I think its best if the already existing
test cases aren't changed, so they should expect the same results as before and
pass. The new test cases should validate the added functionality.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
