arjansh commented on a change in pull request #230: dev/add datatypes to excel columns URL: https://github.com/apache/metamodel/pull/230#discussion_r333952489
########## File path: excel/src/main/java/org/apache/metamodel/excel/ExcelInsertBuilder.java ########## @@ -149,8 +151,33 @@ protected CellStyle fetch() { cell.setCellStyle(cellStyle.get()); } } + validateUpdateType(row); Review comment: I'm not sure what the value is of adding this here. I think that for now it may be best to skip the "validation" part. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services