arjansh commented on a change in pull request #230: dev/add datatypes to excel
columns
URL: https://github.com/apache/metamodel/pull/230#discussion_r333947602
##########
File path:
excel/src/main/java/org/apache/metamodel/excel/ExcelConfiguration.java
##########
@@ -102,17 +115,33 @@ public boolean isSkipEmptyColumns() {
return skipEmptyColumns;
}
+ /**
+ * Defines if columns in the excel spreadsheet should be validated on
datatypes while
+ * reading the spreadsheet.
+ *
+ * @return a boolean indicating whether or not to validate column types.
+ */
+ public boolean isDetectColumnTypes() {
+ return detectColumnTypes;
+ }
+
@Override
protected void decorateIdentity(List<Object> identifiers) {
identifiers.add(columnNameLineNumber);
identifiers.add(skipEmptyLines);
identifiers.add(skipEmptyColumns);
+ identifiers.add(detectColumnTypes);
}
@Override
public String toString() {
return "ExcelConfiguration[columnNameLineNumber="
+ columnNameLineNumber + ", skipEmptyLines=" +
skipEmptyLines
- + ", skipEmptyColumns=" + skipEmptyColumns +
"]";
+ + ", skipEmptyColumns=" + skipEmptyColumns +",
detectColumnTypes="
+ + detectColumnTypes + "]";
+ }
+
+ public int getEagerness() {
+ return eagerReader;
Review comment:
Can you rename this method and the underlying field to something different?
When I see "eager" in combination with "reader", I interpret it as the opposite
of "lazy reading", which is not what this method is about. I would rather see
something like `getNumberOfLinesToScan`, `getScanLines` or something even
better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
