arjansh commented on a change in pull request #230: dev/add datatypes to excel
columns
URL: https://github.com/apache/metamodel/pull/230#discussion_r339452405
##########
File path: excel/src/main/java/org/apache/metamodel/excel/ExcelUtils.java
##########
@@ -414,13 +414,13 @@ public static Style getCellStyle(Workbook workbook, Cell
cell) {
*/
public static DefaultRow createRow(Workbook workbook, Row row,
DataSetHeader header) {
final int size = header.size();
- final String[] values = new String[size];
+ final Object[] values = new Object[size];
final Style[] styles = new Style[size];
if (row != null) {
for (int i = 0; i < size; i++) {
final int columnNumber =
header.getSelectItem(i).getColumn().getColumnNumber();
final Cell cell = row.getCell(columnNumber);
- final String value = ExcelUtils.getCellValue(workbook, cell);
+ final Object value = ExcelUtils.getCellValue(workbook, cell);
Review comment:
Returning an Object doesn't do the trick, we know based on the column type,
what type of object should be returned, so use that to either return a String,
Integer, Boolean or Date object.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
