arjansh commented on a change in pull request #230: dev/add datatypes to excel
columns
URL: https://github.com/apache/metamodel/pull/230#discussion_r338471069
##########
File path:
excel/src/main/java/org/apache/metamodel/excel/XlsxSpreadsheetReaderDelegate.java
##########
@@ -152,10 +160,150 @@ public void close() throws IOException {
});
}
+ private ColumnType[] getColumnTypes(final Sheet sheet, final Row row) {
Review comment:
You are copy/pasting a lot of code into this class from the
`DefaultSpreadsheetReaderDelegate` class, that seems like a bad idea to me, why
not always use the `DefaultSpreadsheetReaderDelegate` in case you need to
detect column types and don't change anything in this class?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
