Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/585#discussion_r116741758
--- Diff:
metron-platform/metron-pcap-backend/src/main/java/org/apache/metron/spout/pcap/PartitionHDFSWriter.java
---
@@ -183,14 +219,14 @@ private void turnoverIfNecessary(long ts, boolean
force) throws IOException {
}
}
- writer = SequenceFile.createWriter(new Configuration()
+ writer = SequenceFile.createWriter(this.fsConfig
, SequenceFile.Writer.keyClass(LongWritable.class)
, SequenceFile.Writer.valueClass(BytesWritable.class)
, SequenceFile.Writer.stream(outputStream)
,
SequenceFile.Writer.compression(SequenceFile.CompressionType.NONE)
);
//reset state
- LOG.info("Turning over and writing to " + path);
+ LOG.info(String.format("Turning over and writing to %s: [duration=%s
NS, force=%s, initial=%s, overDuration=%s, tooManyPackets=%s]", path, duration,
force, initial, overDuration, tooManyPackets));
--- End diff --
Couldn't this be formatted using the Logger's built-in lazy token
replacement, rather than the String.format?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
