Github user justinleet commented on a diff in the pull request:

    https://github.com/apache/metron/pull/585#discussion_r116823693
  
    --- Diff: 
metron-platform/metron-pcap-backend/src/main/java/org/apache/metron/spout/pcap/HDFSWriterCallback.java
 ---
    @@ -116,7 +117,11 @@ public HDFSWriterCallback withConfig(HDFSWriterConfig 
config) {
         public List<Object> apply(List<Object> tuple, EmitContext context) {
             byte[] key = (byte[]) tuple.get(0);
             byte[] value = (byte[]) tuple.get(1);
    -        if(!config.getDeserializer().deserializeKeyValue(key, value, 
KeyValue.key.get(), KeyValue.value.get())) {
    --- End diff --
    
    KeyValue as a whole is unused now, right?  Can we just delete the class 
entirely at this point?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to