Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/585#discussion_r116791055
--- Diff:
metron-platform/metron-pcap-backend/src/main/java/org/apache/metron/spout/pcap/deserializer/KeyValueDeserializer.java
---
@@ -28,6 +26,17 @@
public abstract class KeyValueDeserializer implements Serializable {
protected TimestampConverter converter;
+ public static class Result {
--- End diff --
Well, to be fair, it's `KeyValueDeserializer.Result` since it's a static
inner class, not just `Result`. I'm inclined to think the naming is fine given
the parent class, but I'm open to being convinced otherwise.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
